Gate downloading of git resources#174
Conversation
Signed-off-by: Maysun J Faisal <[email protected]>
Signed-off-by: Maysun J Faisal <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 59.73% 59.72% -0.02%
==========================================
Files 41 41
Lines 5119 5125 +6
==========================================
+ Hits 3058 3061 +3
- Misses 1866 1868 +2
- Partials 195 196 +1
☔ View full report in Codecov by Sentry. |
mike-hoang
left a comment
There was a problem hiding this comment.
Looks good! Should we add a small update to the readme doc about the new parser arg too?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, mike-hoang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Maysun J Faisal <[email protected]>
|
@mike-hoang README has been updated |
|
/lgtm |
What does this PR do?:
Gates the logic for downloading git resources. Clients od devfile/library may be running behind a proxy, so we cannot invoke git operations as they may fail
Which issue(s) this PR fixes:
Fixes devfile/api#1176
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer: