-
Notifications
You must be signed in to change notification settings - Fork 93
Update runtime image to Red Hat UBI 9 PHP 8.3 #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sbouchet The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @sbouchet. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fix eclipse-che/che#23519 Signed-off-by: Stephane Bouchet <[email protected]>
1b4296d to
3d10910
Compare
Signed-off-by: Stephane Bouchet <[email protected]>
| targetPort: 8000 | ||
| protocol: https | ||
| image: quay.io/devfile/composer:2.5.8 | ||
| image: quay.io/devfile/universal-developer-image:ubi9-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the image is going to be changed - maybe it makes sense to create a new version (2.0.2) + add changes to the stack.yaml file
@thepetk could you take a look please
Description of Changes
Update runtime image to Red Hat UBI 9 PHP 8.3 for php laravel sample
Related Issue(s)
fixes eclipse-che/che#23519
fixes eclipse-che/che#23626
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.