Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yhabib
Copy link
Contributor

@yhabib yhabib commented Oct 22, 2025

Motivation

  • Set safe defaults for RegistryCanisterInitPayload to handle new optional arguments and avoid issues with NNS extension.

Solution

  • Default values are provided for the new Registry canister initialization arguments.
  • Change pocket-ic tests target from mainnet to head. This will be reverted once these changes reach the mainnet - NNS1-4259

@github-actions github-actions bot added the fix label Oct 22, 2025
@yhabib yhabib force-pushed the registry/optional-init-args branch 3 times, most recently from 80ffcff to e701a58 Compare October 23, 2025 13:43
@yhabib yhabib force-pushed the registry/optional-init-args branch from e701a58 to 1946a45 Compare October 23, 2025 13:49
@yhabib yhabib marked this pull request as ready for review October 23, 2025 14:28
@yhabib yhabib requested review from a team as code owners October 23, 2025 14:28
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in love with the idea of disabling tests. What if there is a bug that would have been detected by the disabled tests? I guess the window for that is small, but it's nonzero...

@yhabib yhabib changed the title fix(nns): init args for the registry canister fix(nns): safe defaults for registry init args Oct 23, 2025
@yhabib yhabib dismissed github-actions[bot]’s stale review October 23, 2025 17:23
  1. No changes in behavior.

  2. No breaking changes.

  3. No data migration required.

  4. Not necessary.

@yhabib yhabib requested a review from a team as a code owner October 23, 2025 20:50
@github-actions github-actions bot added the @dre label Oct 23, 2025
@yhabib yhabib force-pushed the registry/optional-init-args branch from 04edac2 to 54623e0 Compare October 24, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants