Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ShahriarJavidi
Copy link
Contributor

@ShahriarJavidi ShahriarJavidi commented Oct 23, 2025

This PR activates the feature flag for the neuron index feature as well as updating the release logs from the last week.
Can be merged after <Previous PR|

@ShahriarJavidi ShahriarJavidi requested a review from a team as a code owner October 23, 2025 15:35
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@github-actions github-actions bot added the feat label Oct 23, 2025
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ShahriarJavidi ShahriarJavidi dismissed github-actions[bot]’s stale review October 24, 2025 10:49

Changes are included in the change log.

@ShahriarJavidi ShahriarJavidi added this pull request to the merge queue Oct 24, 2025
Merged via the queue into master with commit 31a5282 Oct 24, 2025
31 checks passed
@ShahriarJavidi ShahriarJavidi deleted the Shah/NNS1-4237 branch October 24, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants