Enable NVPL in CMake #284
Enable NVPL in CMake #284
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
===========================================
+ Coverage 41.13% 57.16% +16.03%
===========================================
Files 33 51 +18
Lines 2966 4338 +1372
Branches 1347 1572 +225
===========================================
+ Hits 1220 2480 +1260
+ Misses 1005 857 -148
- Partials 741 1001 +260 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| set(BLA_SIZEOF_INTEGER 8) | ||
| set(_nvpl_int "_ilp64") | ||
| else() | ||
| set(BLA_SIZEOF_INTEGER 4) |
There was a problem hiding this comment.
This was not set in grimme-lab/multicharge#44. Is this required?
There was a problem hiding this comment.
Good catch! It is usually found by default, but it would indeed be better to be explicit. I'll update multicharge to do the same.
There was a problem hiding this comment.
I just noticed that BLA_SIZEOF_INTEGER was only added in CMake 3.22 according to CMake's FindBLAS.cmake you linked.
There was a problem hiding this comment.
Yes, before [email protected] this is not used. Maybe it's better to bump the minimum CMake version to 3.22. What do you think?
| DIRECTORY ${PROJECT_SOURCE_DIR}/config/cmake/ | ||
| DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME} | ||
| FILES_MATCHING | ||
| PATTERN "Find*.cmake" |
There was a problem hiding this comment.
Should this be limited to only the Find modules and not include the macro file?
NVPL is not supported by CMake before version
4.1. This PR adds "manual" support for NVLP. Related to grimme-lab/multicharge#44.Closes #273.