Make the intervall of the sensor fan configurable and the poll timer of properties. #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR makes the sensor fan polling interval and property poll timer configurable for Xiaomi Mi Air Purifier 3C devices. The motivation is to reduce noise and wear on the sensor fan by allowing users to control how frequently the sensor is activated.
Key Changes
- Added configurable poll interval for property updates (previously hardcoded to 60 seconds)
- Added configurable heartbeat interval and value for sensor fan control
- Made all timing parameters configurable through the YAML configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| components/miot/miot.h | Added setter methods and member variables for poll_interval, heartbeat_value, and heartbeat_interval configuration |
| components/miot/miot.cpp | Updated setup() to use configurable intervals instead of hardcoded 60000ms values |
| components/miot/init.py | Added configuration schema entries and initialization code for the new configurable parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Author
|
I tried it now on my C3 and it works well. |
Author
|
Now the Values takes affect also without flashing new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have my Xiaomi-Mi-Air-Purifier-3C in my bedroom and the fan of the sensor is quite loud and also the fan gets very fast bad when it is running 24/7 i know that because i have many of such little fans running for pi cluster as example.
So i make the intervall time in which is the sensor gets readed configurable and i saw that the poll rate of properties is also fix at 60s so i make that also in the same way configurable. with that code it should be possible to controll it like
that should run the pm2.5 sensor for 10s every 30s as example.