Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(SimpleSingleSelect): update TS types, export and docs #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kabaros merged 3 commits into from
Dec 17, 2025
Merged

fix(SimpleSingleSelect): update TS types, export and docs #1713

kabaros merged 3 commits into from
Dec 17, 2025

Conversation

@kabaros
Copy link
Collaborator

@kabaros kabaros commented Dec 16, 2025 •
edited
Loading

This PR

  • updates the developer docs to remove the duplicated select entries
  • fixes several types mismatch with the documentation and component
  • makes sure the type for the new component is exported at the top level

These are relatively urgent fixes, but then there are other followups that needs some time/thinking:

  • general update to the Select page to have more examples for the new component (now there is one example + reference)
  • Jan-Gerke wrote some "recipes" for the new component, but we don't seem to have such a section now - so need to know where to put them, and refer to them.

@kabaros kabaros requested a review from a team as a code owner December 16, 2025 22:48
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Dec 16, 2025 •
edited
Loading

🚀 Deployed on https://pr-1713--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify December 16, 2025 22:53 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 17, 2025 13:20 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dhis2-bot dhis2-bot temporarily deployed to netlify December 17, 2025 13:24 Inactive
@kabaros kabaros enabled auto-merge (squash) December 17, 2025 13:25
@kabaros kabaros merged commit d3e7ed4 into master Dec 17, 2025
17 checks passed
@kabaros kabaros deleted the docs/update-select branch December 17, 2025 13:33
dhis2-bot added a commit that referenced this pull request Dec 17, 2025
@dhis2-bot
chore(release): cut 10.10.2 [skip release]
8df34ae 
## [10.10.2](v10.10.1...v10.10.2) (2025-12-17)

### Bug Fixes

* **SimpleSingleSelect:** update TS types, export and docs  ([#1713](#1713)) ([d3e7ed4](d3e7ed4))
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Dec 17, 2025

🎉 This PR is included in version 10.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KaiVandivier KaiVandivier KaiVandivier approved these changes

@henrikmv henrikmv Awaiting requested review from henrikmv

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kabaros @dhis2-bot @KaiVandivier