import PROT_READ , solve types of sys_fstat/sys_mmap params. #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change type of buf in sys_fstat Change type of flags in sys_mmap
digama0
reviewed
Dec 21, 2025
|
|
||
| (intrinsic @ proc (sys_fstat {fd : u32} | ||
| (mut {(ghost buf) : (? Stat)}) {p : (&sn buf)} : | ||
| (mut {(ghost buf) : (ref Stat)}) {p : (&sn buf)} : |
Owner
There was a problem hiding this comment.
I don't think this is correct; the type is (? Stat) because it need not be initialized before the function call.
digama0
reviewed
Dec 21, 2025
| (intrinsic @ proc (sys_mmap {pos : (sn {0 : u64})} {len : u64} {prot : u32} | ||
| {(ghost anon) : bool} | ||
| {flags : (sn {(if anon MAP_PRIVATE {MAP_PRIVATE + MAP_ANONYMOUS}) : u64})} | ||
| {flags : (sn {(if anon MAP_PRIVATE {MAP_PRIVATE + MAP_ANONYMOUS}) : nat})} |
Owner
There was a problem hiding this comment.
the flags are a u64 because it's a non-ghost argument to the function passed in one of the registers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import PROT_READ
Change type of buf in sys_fstat
Change type of flags in sys_mmap