Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Apps: Display "phase" for apps get-deployments #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2023
Merged

Apps: Display "phase" for apps get-deployments #1468

merged 3 commits into from
Dec 7, 2023

Conversation

danaelhe
Copy link
Member

@danaelhe danaelhe commented Dec 7, 2023

Address #1460

Adding "Phase" to apps get-deployment display so users know if deployment is still in progress, cancelled, or finished etc. Currently there's only a "Progress" display but, for example, a progress field with "6/7" could mean a lot of things (i.e. is the deployment still in progress? is it cancelled and stoped at 6th step? etc.)

Before:

 % doctl apps get-deployment 3785-4bc2  e652-401c-8794
ID                                      Cause               Progress    Created At                       Updated At
e652-401c-8794    app spec updated    6/7         2023-09-12 13:49:39 +0000 UTC    2023-09-12 13:49:50 +0000 UTC

After:

go run cmd/doctl/main.go  apps get-deployment 3785-4bc2  e652-401c-8794
ID                                      Cause               Progress    Phase     Created At                       Updated At
216b3799-e652-401c-8794-9b1c0ba35238    app spec updated    7/7         ACTIVE    2023-09-12 13:49:39 +0000 UTC    2023-09-12 13:49:50 +0000 UTC

@danaelhe
Copy link
Member Author

danaelhe commented Dec 7, 2023

Fixing tests...one sec

andrewsomething
andrewsomething approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewsomething andrewsomething merged commit 5080070 into main Dec 7, 2023
@andrewsomething andrewsomething deleted the apps_status branch December 7, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

@bentranter bentranter Awaiting requested review from bentranter

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danaelhe @andrewsomething