Thanks to visit codestin.com
Credit goes to github.com

Add (half)SipHash implementation #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

robxyy merged 4 commits into diglol:trunk from Entreco:trunk

Jan 6, 2024

Contributor

Entreco commented Jan 4, 2024

KMM implementation of (half)SipHash
Let me know your throughts, feedback, suggestions


          Add (half)SipHash implementation

f35ef1a

Entreco mentioned this pull request

Feature Request: Add support for (half)Siphash #107

Closed


          Fix unit tests

0315c5e

robxyy reviewed

View reviewed changes

README.md Show resolved Hide resolved

robxyy reviewed

View reviewed changes

siphash/build.gradle.kts Outdated Show resolved Hide resolved

robxyy reviewed

View reviewed changes

siphash/src/commonMain/kotlin/diglol/crypto/SipKey.kt Outdated Show resolved Hide resolved

robxyy reviewed

View reviewed changes

siphash/src/commonMain/kotlin/diglol/crypto/SipKey.kt Outdated Show resolved Hide resolved

robxyy reviewed

View reviewed changes

siphash/src/commonMain/kotlin/diglol/crypto/SipKey.kt Outdated Show resolved Hide resolved

robxyy reviewed

View reviewed changes

siphash/src/commonTest/kotlin/diglol/crypto/HalfSipHashTest.kt Outdated Show resolved Hide resolved

robxyy reviewed

View reviewed changes

siphash/src/commonTest/kotlin/diglol/crypto/HalfSipHashTest.kt Show resolved Hide resolved

robxyy reviewed

View reviewed changes

siphash/src/commonTest/kotlin/diglol/crypto/SipHashTest.kt Outdated Show resolved Hide resolved

robxyy reviewed

View reviewed changes

siphash/src/commonTest/kotlin/diglol/crypto/SipHashTest.kt Show resolved Hide resolved

robxyy requested changes

View reviewed changes

Contributor

robxyy left a comment

Looks great but needs some minor tweaks.


          Include Review Comments

a65f11a

Contributor Author

Entreco commented Jan 5, 2024

Thanks for your quick review, much appreciated!
I've pushed the requested tweaks.

I am only able to run the tests on a Windows machine.
No clue if we need additional testing other (native) targets, I'll leave that up to you.

Btw, is it possible to add badges to the README with the supported platforms/targets?
Something like this should work I guess:

![badge-platform-android]
![badge-platform-jvm]
![badge-platform-js]

Contributor

robxyy commented Jan 5, 2024

I am only able to run the tests on a Windows machine. No clue if we need additional testing other (native) targets, I'll leave that up to you.

Don't worry, Unit-tests passed. See runs

Btw, is it possible to add badges to the README with the supported platforms/targets? Something like this should work I guess:
![badge-platform-android]
![badge-platform-jvm]
![badge-platform-js]

LGTM, currently supports Tier 2


          Update README with supported targets

64721de

robxyy merged commit e389204 into diglol:trunk

Contributor Author

Entreco commented Jan 8, 2024

Do you already know when you would like to publish a new version? No pressure, just curious :)

Contributor

robxyy commented Jan 8, 2024

@Entreco v0.2.0 has been released and will be pushed to Maven in about 1 hour :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet