Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@discosultan
Copy link
Owner

Fixes #25

@WardBenjamin
Copy link
Contributor

Looks good to me on paper; I haven't had a chance to test.

@amerkoleci
Copy link
Contributor

ppEnabledLayerNames is deprecated and ignored.
So this one doesn't make sense tho.

https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkDeviceCreateInfo.html

@discosultan
Copy link
Owner Author

The only reason for the change is to make it possible to define those layers in case someone is targeting a very early version of Vulkan runtime. Note that it's documented as deprecated and also not exposed in the constructor signature.

@amerkoleci
Copy link
Contributor

I see, maybe marking the EnabledLayerCount and EnabledLayerNames with Deprecated attribute would help that approach.

@WardBenjamin
Copy link
Contributor

WardBenjamin commented Jun 18, 2018

Not a bad idea - the field should be marked with an [Obsolete("Reason")] attribute (but not the [Obsolete("Reason", true)] variant, which would mark it as an error when used).

@discosultan discosultan merged commit 9e99572 into master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants