Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[feat] dark mode and theme toggle #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: 2024 hackweek
merged 15 commits into from
Oct 29, 2024
Merged

[feat] dark mode and theme toggle #174

merged 15 commits into from
Oct 29, 2024

Conversation

@amyjchen
Copy link
Contributor

@amyjchen amyjchen commented Oct 28, 2024 •
edited
Loading

Changes Made

  • applies dark mode theme according to system settings
  • adds toggle to bottom left of nav for overriding system default
  • adjusts some components to use theme-specific values instead of hardcoded greys
  • adds separate type file for custom palette overrides
  • adjusts NumberInput to match themes and existing MUI components
  • moves styled bulk action table into own component
  • makes primary_extra_light into a variant of primary
  • adds text.accent variant and uses in place of primary. swaps typography use of grey for text.secondary
Before After (Light) After (Dark)
Screenshot 2024-10-28 at 15 22 04 Screenshot 2024-10-28 at 15 21 03 Screenshot 2024-10-29 at 13 10 43
Screenshot 2024-10-28 at 15 21 47 Screenshot 2024-10-28 at 15 20 24 Screenshot 2024-10-29 at 13 10 53
Screenshot 2024-10-29 at 13 20 10 Screenshot 2024-10-29 at 13 11 25 Screenshot 2024-10-29 at 13 11 14
Screenshot 2024-10-29 at 13 20 06 Screenshot 2024-10-29 at 13 08 21 Screenshot 2024-10-29 at 13 08 17
hovering over bottom button:
Screenshot 2024-10-29 at 13 24 14 Screenshot 2024-10-29 at 13 25 08 Screenshot 2024-10-29 at 13 25 22
Screenshot 2024-10-29 at 13 32 23 Screenshot 2024-10-29 at 13 33 09 Screenshot 2024-10-29 at 13 42 49

@amyjchen amyjchen changed the title [feat] adds dark mode and toggle [feat] uses dark mode and toggle Oct 28, 2024
@amyjchen amyjchen marked this pull request as ready for review October 28, 2024 22:27
@amyjchen amyjchen changed the title [feat] uses dark mode and toggle [feat] uses dark mode and adds theme toggle Oct 28, 2024
@eguerrant
Copy link
Contributor

I'm not committed to this but it might be nice to have a little more contrast between the background color and card color in darkmode? They're almost the same and it's hard to see the outline of the cards haha

amyjchen added 15 commits October 29, 2024 15:00
@amyjchen amyjchen changed the title [feat] uses dark mode and adds theme toggle [feat] dark mode and theme toggle Oct 29, 2024
@amyjchen amyjchen merged commit 813fcd4 into 2024-hackweek Oct 29, 2024
6 checks passed
@amyjchen amyjchen deleted the feat/dark-mode branch October 29, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amyjchen @eguerrant