Role requests API #175
Merged
Role requests API #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sa.ForeignKeyConstraint(['resolver_user_id'], ['okta_user.id'], name=op.f('fk_role_request_resolver_user_id_okta_user')), | ||
| sa.PrimaryKeyConstraint('id', name=op.f('pk_role_request')) | ||
| ) | ||
| with op.batch_alter_table('access_request', schema=None) as batch_op: |
Collaborator
There was a problem hiding this comment.
Interesting, I'm not sure why all these existing columns had nullable=True in the initial migration https://github.com/discord/access/blob/main/migrations/versions/d6db40b0805d_initial_migration.py
Collaborator
|
Looks like the tests aren't passing quite yet, but it's getting close! |
somethingnew2-0
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding role requests (like access requests but so that role owners can request that their roles are added to a group).
This is just the API piece. The UI will be in a separate PR.
I have no clue how to fix the last failing test atm...