Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[fix] dark mode bugs #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: 2024 hackweek
merged 6 commits into from
Oct 31, 2024
Merged

[fix] dark mode bugs #179

merged 6 commits into from
Oct 31, 2024

Conversation

@amyjchen
Copy link
Contributor

@amyjchen amyjchen commented Oct 31, 2024 •
edited
Loading

Changes made

  • Updates Chips on app and group pages to use .disabled instead of .disabledBackground for visibilitiy
  • Updates outlined primary chips to use the text-primary color
  • updates theme selection to have a "system option"

Before

Screen.Recording.2024-10-31.at.12.36.43.mov

After

Screen.Recording.2024-10-31.at.12.23.16.mov

@amyjchen amyjchen marked this pull request as ready for review October 31, 2024 19:38
@amyjchen amyjchen merged commit 01f5b77 into 2024-hackweek Oct 31, 2024
6 checks passed
@amyjchen amyjchen deleted the fix/dark-mode-bugs branch October 31, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@somethingnew2-0 somethingnew2-0 somethingnew2-0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amyjchen @somethingnew2-0