Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jonathanhle
Copy link
Contributor

@jonathanhle jonathanhle commented Apr 2, 2025

On our Okta tenant we use Custom Attributes for the Okta Group profile. When updating Okta groups from the UI, we noticed that the Custom Attributes are getting wiped out.

Updated update_group to pull the current Okta Group profile data, merge in the updates, and use that new payload for the okta_client.update_group call.

Added new test for it.

Passes tests and in my local testing against a Okta Preview tenant, it appears to be working as desired.

@jonathanhle jonathanhle closed this Apr 2, 2025
@jonathanhle jonathanhle reopened this Apr 2, 2025
@jonathanhle jonathanhle changed the title Enhance update_group to preserve custom attributes and improve error … Preserve custom attributes on Discord Access Okta Group UI updates Apr 2, 2025
@jonathanhle jonathanhle marked this pull request as ready for review April 2, 2025 21:22
somethingnew2-0
somethingnew2-0 previously approved these changes Apr 2, 2025
Copy link
Collaborator

@somethingnew2-0 somethingnew2-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding this and the test!

@somethingnew2-0 somethingnew2-0 enabled auto-merge (squash) April 2, 2025 23:18
@somethingnew2-0 somethingnew2-0 merged commit 8327347 into discord:main Apr 2, 2025
3 checks passed
@jonathanhle jonathanhle deleted the jle-PLATSEC-4056-deal-with-custom-attrs branch April 3, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants