Jle platsec 3706 redact token log #265
Merged
+62
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…horization codes in application and access logs
…ted Gunicorn logger
|
Very nice! Change this PR out of draft when you're ready and I can take a final review |
Will update the mypy stuff and then go out of draft. Need a bit. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces log redaction improvements to mask sensitive token and authorization code information in application and access logs.
- Adds a TokenSanitizingFilter to sanitize token data in application logs.
- Implements a RedactingGunicornLogger to strip query strings from access logs for the /oidc/authorize endpoint.
- Updates app initialization to apply the new log filters to various loggers.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| api/log_filters.py | Adds token redaction filtering logic and a custom Gunicorn logger for access logs. |
| api/app.py | Updates application logging configuration to include the new token sanitizing filter. |
Files not reviewed (1)
- Dockerfile: Language not supported
|
@somethingnew2-0 fixed the mypy errors. Tested on my local and the logging redactions of the tokens are taking place. |
eguerrant
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose log redactions for tokens/strings we'd be more comfortable if they were redacted.