[sentry] Add sentry breadcrumbing for referrer query param #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds tracking of a source query parameter via Sentry breadcrumbs and tags to capture referrer context.
- Import and use
useSearchParamsto extractsourcefrom the URL. - Introduce an
AppStatecomponent that logs a breadcrumb and sets a Sentry tag whensourceis present. - Refactor theme-setting logic into a separate
updateModecallback and split offAppState.
Comments suppressed due to low confidence (2)
src/App.tsx:282
- [nitpick] The variable name
sourceis quite generic; consider renaming it to something more descriptive likereferrerSourceto clarify its purpose.
const source = searchParams.get('source') ?? undefined;
src/App.tsx:363
- Consider adding unit or integration tests to verify that when a
sourcequery param is provided,Sentry.addBreadcrumbandSentry.setTagare invoked correctly.
React.useEffect(() => {
| if (source) { | ||
| Sentry.addBreadcrumb({ | ||
| category: 'navigation', | ||
| message: `Access navigation from source referrer`, |
There was a problem hiding this comment.
[nitpick] The breadcrumb message is a bit unclear; rephrase to something like Navigation accessed from referrer source or include the actual source value for clarity.
Suggested change
| message: `Access navigation from source referrer`, | |
| message: `Navigation accessed from referrer source: ${source}`, |
somethingnew2-0
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.