Show expiration date on chip hover #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit - is the ending_date UTC? Could be good to append a timezone to the string to make it clear or localize based on viewer's current TZ |
All the dates shown in Access are in UTC. Fixing that everywhere would be good in the future but for now I feel like being consistent makes more sense |
savathoon
approved these changes
Jun 3, 2025
|
We could probably use the code in #250 to try and get time zone local timestamps working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has direct access and access via one or more roles, it can be unclear if one is granting longer access than the other since the 'Ending' column just shows the max. Added labels on hover to show expiration dates associated with each membership/ownership. Left the date format the same as on other pages (eg. the Access Request list page) to be consistent