JSX Refactor: Common empty list item component #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the way empty table rows are rendered by introducing a common component () to replace repeated inline markup displaying "None" across request and group pages, while also applying minor layout adjustments in the App component.
- Replace inline "None" table rows in requests and groups with
- Introduce a reusable EmptyListEntry component with customizable cell properties and text
- Update App.tsx with additional Box styling for improved layout
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/pages/requests/Read.tsx | Replaces hardcoded "None" rows with in three tables |
| src/pages/groups/Read.tsx | Replaces inline "None" row with for group details |
| src/components/EmptyListEntry.tsx | Adds a new reusable component to render empty list table entries |
| src/App.tsx | Enhances Box styling with a minimum width and overflow settings |
| </Typography> | ||
| </TableCell> | ||
| </TableRow> | ||
| <EmptyListEntry /> |
There was a problem hiding this comment.
Consider providing consistent cellProps (e.g. { colSpan: 3 }) for across all table usages to maintain uniform table layout.
|
|
||
| return ( | ||
| <Box sx={{display: 'flex'}}> | ||
| <Box sx={{display: 'flex', minWidth: '20rem', overflowX: 'hidden'}}> |
There was a problem hiding this comment.
How does this affect the app layout?
somethingnew2-0
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving isolated improvements from the app group feature branch into main