App owner group description bug #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Ensures that when an application is renamed, its owner group’s description is also updated for future name changes.
- Add conditional logic to set the owner group's description to use the new app name
- Continue to invoke
okta.update_groupwith the updated description
Comments suppressed due to low confidence (1)
api/views/resources/app.py:152
- Add a unit or integration test to verify that when an app is renamed, the owner group’s description is updated accordingly.
if app_group.is_owner:
api/helpers.py
Outdated
There was a problem hiding this comment.
Can we move this to https://github.com/discord/access/blob/main/api/models/app_group.py ?
barborico
previously approved these changes
May 28, 2025
somethingnew2-0
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the description of the app owners group is not changed when an app is renamed so it'll still say "Owners of the application" and app owner group descriptions can't be modified in the Access UI. Fixes this for new name changes (not existing name mismatches)