Add hover styles highlight, make table row clickable when all items link to same page #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somethingnew2-0
previously approved these changes
Jun 10, 2025
…or membership list
…render highlight color on hover and respect unique links within same row
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces hover styles to highlight clickable rows and updates the table components on several pages to improve the clickable experience. Key changes include:
- Adding hover effects (background color and color changes) to list and detail views on users, roles, groups, and apps.
- Replacing standard TableRow elements with a custom LinkTableRow component for entire row clickability.
- Converting individual Link components to clickable rows using onClick and navigate in apps pages.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pages/users/Read.tsx | Added hover styles to link components and audit icon. |
| src/pages/users/List.tsx | Replaced TableRow with LinkTableRow for full row clicks. |
| src/pages/roles/List.tsx | Introduced LinkTableRow for clickable rows and improved description truncation. |
| src/pages/groups/Read.tsx | Applied hover color changes to group links. |
| src/pages/groups/List.tsx | Updated row components to use LinkTableRow. |
| src/pages/apps/Read.tsx | Updated clickable rows with onClick; added hover styling. |
| src/pages/apps/List.tsx | Converted rows to LinkTableRow for full row linking. |
| src/components/LinkTableRow.tsx | Created a reusable component to wrap table rows with a clickable Link. |
Comments suppressed due to low confidence (1)
src/pages/users/Read.tsx:187
- Remove the extra space in the color value ('inherit ') to ensure consistent styling; use 'inherit' instead.
color: 'inherit ',
Comment on lines
+182
to
+185
| sx={{ | ||
| cursor: 'pointer', | ||
| transition: 'all 0.2s ease', | ||
| '&:hover': { |
There was a problem hiding this comment.
Consider adding keyboard accessibility support (e.g., tabIndex and onKeyDown handler) to the clickable TableRow for improved accessibility.
somethingnew2-0
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the tables on the following pages
Out of scope due to list entries with multiple links: