-
Notifications
You must be signed in to change notification settings - Fork 73
Move to using Vite instead of create-react-app #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request migrates from the deprecated create-react-app (CRA) to Vite as the build tool for improved performance and ongoing support. The migration involves updating the build configuration, environment variable naming conventions, and dependency management.
- Replace CRA and CRACO with Vite configuration and plugins
- Update environment variable references from
process.env.REACT_APP_*toimport.meta.env.VITE_* - Migrate Sentry integration from CLI-based to Vite plugin-based source map handling
Reviewed Changes
Copilot reviewed 11 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | New Vite configuration with React plugin, Sentry integration, and test setup |
| package.json | Updated dependencies and scripts to use Vite instead of CRA/CRACO |
| src/index.tsx | Environment variable updates for Vite compatibility |
| src/api/apiFetcher.ts | Environment variable updates for Vite compatibility |
| src/pages/groups/CreateUpdate.tsx | Fixed operator precedence issue with string concatenation |
| index.html | Updated HTML template for Vite with direct script imports |
| craco.config.js | Removed obsolete CRACO configuration file |
| Dockerfile | Updated build process to use Vite and new Sentry plugin approach |
| .vscode/settings.json | Removed Python-specific settings unrelated to the migration |
| .github/workflows/docker-image.yml | Updated Sentry secrets configuration for new plugin |
| .env.production.example | Updated environment variable naming convention |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
savathoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions but otherwise LGTM
Given [this PR](discord#325), I believe the documentation needs to be updated to reflect the use of Vite.
Given [this PR](discord#325), I believe the documentation needs to be updated to reflect the use of Vite.
Given [this PR](discord#325), I believe the documentation needs to be updated to reflect the use of Vite.
create-react-appis deprecated and no longer being maintained, move to a more supported build tool insteadhttps://react.dev/blog/2025/02/14/sunsetting-create-react-app