sendmmsg() on linux #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- define DISCORD_ENABLE_SENDMMSG to build with sendmmsg (i.e. add this when building on linux) - pass in UV_UDP_DISCORD_USE_SENDMMSG in uv_udp_init_ex if you want sendmmsg used on a particular udp handle
adill
approved these changes
Mar 30, 2017
snowyote
pushed a commit
that referenced
this pull request
May 7, 2019
Valgrind will emit the following error on a system where `int` is 32 bits: ==21616== Syscall param epoll_ctl(event) points to uninitialised byte(s) ==21616== at 0x693E06A: epoll_ctl (syscall-template.S:84) ==21616== by 0x529F35B: uv__io_poll (in .../libuv/libuv.so) ==21616== by 0x528AE62: uv_run (in .../libuv/libuv.so) [...] ==21616== Address 0x1ffeffc8ec is on thread 1's stack ==21616== in frame #1, created by uv__io_poll (???:) We only initialise e.events and e.data.fd, meaning half of e.data (the 32 bits not covered by the 4-byte `fd`) is uninitialised. PR-URL: libuv#1996 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
snowyote
pushed a commit
that referenced
this pull request
May 24, 2022
ERROR: LeakSanitizer: detected memory leaks
```
Direct leak of 432 byte(s) in 9 object(s) allocated from:
#0 0x1062eedc2 in __sanitizer_mz_calloc+0x92 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x46dc2)
#1 0x7fff20171eb6 in _malloc_zone_calloc+0x3a (libsystem_malloc.dylib:x86_64+0x1beb6)
#2 0x7fff203ac180 in _CFRuntimeCreateInstance+0x124 (CoreFoundation:x86_64h+0x4180)
#3 0x7fff203ab906 in __CFStringCreateImmutableFunnel3+0x84d (CoreFoundation:x86_64h+0x3906)
#4 0x7fff203ab0a1 in CFStringCreateWithCString+0x48 (CoreFoundation:x86_64h+0x30a1)
#5 0x1056f63e1 in uv__get_cpu_speed darwin.c:267
#6 0x1056f491e in uv_cpu_info darwin.c:338
```
PR-URL: libuv#3098
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pickin up the work from andy. this is a little weirdly shaped so suggestions welcome.
The intent is, if you compile with
-DDISCORD_ENABLE_SENDMMSGthen the sendmmsg() code will be compiled (so we omit that define on non-linux). However, theuse_sendmmsgfield onuv_udp_tis present on any *nix, and theUV_UDP_DISCORD_USE_SENDMMSGflag is present on every platform.To actually use
sendmmsgon a givenuv_udp_tyou calluv_udp_init_exwith theUV_UDP_DISCORD_USE_SENDMMSGflag.If the flag is weird I could keep the field and just add a post-init function that turns on
use_sendmmsg(or we could just write to it ourselves). Lmk whatchu thinks