feat(gif): Add GIF animation loop count detection for animated WebP conversion #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulltrope
approved these changes
Nov 7, 2024
- Enhance loop count detection to handle multiple extension blocks - Add proper cleanup and error handling in GIF parsing - Add test cases for duplicate loop counts and multiple extensions
skidder
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to detect and propagate loop count information from animated GIF sources to WebP outputs. Previously, all GIFs were treated as infinitely looping, but this change allows proper handling of GIFs with specific loop counts (e.g., play once, play N times).
Changes
giflib_decoder_get_loop_count()C++ function to parseNETSCAPE2.0extension blocksLoopCount()method to return actual loop countTechnical Details
NETSCAPE2.0extension block is parsed to extract loop count informationTesting