fix: remove c++ includes from tone_mapping.hpp #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the tone_mapping.hpp header was including <opencv2/opencv.hpp>, which pulls in tons of c++ template types (cv::Scalar_, std::vector, std::shared_ptr, etc). bindgen was generating layout tests for these templates but couldn't determine their correct sizes, causing test failures.
remiolivier-discord
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
fix lilliput bindgen layout tests by removing c++ includes from
tone_mapping.hppthe
tone_mapping.hppheader was including <opencv2/opencv.hpp>, which pulls in tons of c++ template types (cv::Scalar_, std::vector, std::shared_ptr, etc). bindgen was generating layout tests for these templates but couldn't determine their correct sizes, causing test failures.ffi only needs the c function
apply_tone_mapping_ffi, we don't need the c++ implementation details. this PR fixes that.