Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kyranet
Copy link
Member

@kyranet kyranet commented Apr 28, 2021

Please describe the changes this PR makes and why it should be merged:

This PR adds pre-builds for Node.js v16, as the title says.

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@kyranet
Copy link
Member Author

kyranet commented Apr 28, 2021

Should I leave this for a few days and re-run actions later, or remove Node.js v16 pre-builds for musl, as there are build errors with it?

cc: @iCrawl

@Mesteery
Copy link

Mesteery commented May 1, 2021

For musl, you should install python3 (or python2) instead of python.

@kyranet
Copy link
Member Author

kyranet commented May 1, 2021

For musl, you should install python3 (or python2) instead of python.

That worked, thanks!

@iCrawl iCrawl added ci dependencies Pull requests that update a dependency file semver:minor labels May 6, 2021
@iCrawl iCrawl merged commit 534f56c into discordjs:master May 6, 2021
@kyranet kyranet deleted the feat/add-prebuild-support-for-node-v16 branch May 6, 2021 16:07
joshuadl12 added a commit to joshuadl12/discordjs-opus-macos-arm64 that referenced this pull request May 19, 2021
feat(ci): add prebuilds for Node.js v16 (discordjs#87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci dependencies Pull requests that update a dependency file semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants