Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jovany-wang
Copy link
Collaborator

The related PR is #250

@jovany-wang jovany-wang requested review from MrKingHH, kairbon and senyer and removed request for kairbon November 9, 2019 07:28
@jovany-wang
Copy link
Collaborator Author

It seems that CI failed with a bug. I will solve it later.

Copy link
Collaborator

@MrKingHH MrKingHH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution very much! But I think using del is more appropriate than using drop. Should we consider it again?

@jovany-wang
Copy link
Collaborator Author

Thanks for your contribution very much! But I think using del is more appropriate than using drop. Should we consider it again?

This is not conflict with drop table command.

Copy link
Collaborator

@MrKingHH MrKingHH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks fou your contribution!

@jovany-wang jovany-wang merged commit 68f403e into distkv-project:master Nov 12, 2019
@jovany-wang jovany-wang deleted the refine_drop branch November 12, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants