docs: remove unused go.mod #4115
Conversation
docs/go.mod
Outdated
| github.com/imfing/hextra v0.5.0 // indirect | ||
| github.com/thegeeklab/hugo-geekdoc v0.41.2 // indirect | ||
| ) | ||
| go 1.20 |
There was a problem hiding this comment.
We could even remove the version, but looks like go mod tidy wants to add "something" back. Technically "any" version would work, so we could set it to something really low.
|
This is probably just my lack of go experience, but, why do we have a go.mod in the docs package at all when there is no code there? |
|
Perhaps it needs a comment; this is used to facilitate Hugo's feature to vendor documentation from multiple repositories; Hugo has a feature to get documentation "modules" from repositories, and it uses the Go modules logic for that; https://gohugo.io/hugo-modules/ The docker documentation currently uses this to combine docs from multiple sources (see https://github.com/docker/docs/blob/main/go.mod) I guess the added benefit is that vendoring @dvdksn may be able to provide more details if needed |
|
@dvdksn would you mind opening a PR that updates the docs that explain this so that whoever picks up some docs related work doesn't have to ask the same questions 😄 |
|
Just checked and the |
|
@thaJeztah do you wanna delete those files as per @dvdksn comment? |
|
Ping @thaJeztah RE: my and @dvdksn's last comments |
This go.mod was used to allow vendoring the docs with Hugo, but this was never used, so we can remove the go.mod altogether. Signed-off-by: Sebastiaan van Stijn <[email protected]>
f7987db to
186d522
Compare
|
whoops, missed your ping; updated and removed the |
Uh oh!
There was an error while loading. Please reload this page.