Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@davidswu
Copy link
Contributor

@davidswu davidswu commented Jan 4, 2019

2.7 port for #2800

Signed-off-by: David Wu [email protected]

@davidswu davidswu added this to the Registry/2.7.1 milestone Jan 4, 2019
@davidswu davidswu requested review from caervs, dmcgowan and dmp42 January 4, 2019 21:48
@davidswu davidswu changed the title default autoredirect to false [2.7] default autoredirect to false Jan 4, 2019
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #2802 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2802      +/-   ##
==========================================
+ Coverage   60.24%   60.25%   +<.01%     
==========================================
  Files         103      103              
  Lines        8022     8024       +2     
==========================================
+ Hits         4833     4835       +2     
  Misses       2546     2546              
  Partials      643      643
Flag Coverage Δ
#linux 60.25% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
registry/auth/token/accesscontroller.go 66.16% <66.66%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b7b58...caf43bb. Read the comment docs.

Copy link
Contributor

@dmp42 dmp42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caervs
caervs previously requested changes Jan 7, 2019
Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooop, actually @davidswu I think you meant to submit this PR against the release/2.7 branch.

@davidswu davidswu changed the base branch from master to release/2.7 January 7, 2019 17:18
@davidswu
Copy link
Contributor Author

davidswu commented Jan 7, 2019

@caervs changed

Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit e702d95 into distribution:release/2.7 Jan 7, 2019
@thaJeztah
Copy link
Member

This was included in the v2.7.1 release; could someone update the milestone accordingly? https://github.com/docker/distribution/blob/v2.7.1/registry/auth/token/accesscontroller.go#L165-L172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants