Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Optimize _decodeJobCreationData function to avoid redundant work #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize _decodeJobCreationData function to avoid redundant work #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions contracts/Ethlance.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,11 +455,9 @@ contract Ethlance is IERC721Receiver, IERC1155Receiver, DSAuth {
createJob(creator, offeredValues, invitedArbiters, ipfsData);
}

// TODO: how to optimize so that multiple calls to this method wouldn't
// redo the work multiple times (and thus spend gas) during one
// contract execution
function _decodeJobCreationData(bytes calldata _data) internal pure returns(OperationType, address, EthlanceStructs.TokenValue[] memory, address[] memory, bytes memory) {
return abi.decode(_data[4:], (OperationType, address, EthlanceStructs.TokenValue[], address[], bytes));
bytes memory data = _data[4:]; // Extract relevant data once
return abi.decode(data, (OperationType, address, EthlanceStructs.TokenValue[], address[], bytes));
}

function isCalledForOneStepJobCreation(bytes calldata _data) internal pure returns(bool) {
Expand Down