Fix suggestions list and loading progressbar labels #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
For reference: the labeling issues were discovered while working on the |
pacocoursey
approved these changes
Jan 30, 2024
Contributor
Author
|
Hello @pacocoursey and thanks for merging this. |
Collaborator
|
@afercia Released in |
Contributor
Author
|
@pacocoursey thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
This PR aims to improve the accessible labels of two components of the user interface.
Also, the current label are hardcoded English text. In projects that are translated to other languages, these labels need to be passed via prop so that they are translatable.
1
The suggestions list.
Currently, it is labelled via both
aria-labelandaria-labelledby. This is redundant asaria-labelledbywill always overridearia-label. Also,aria-labelledbypoints to the search input id. As a result, the list of suggestions is labeled with the term users type in the search field, which is inappropriate.aria-labelledbyattribute.aria-labelvalue.2
Loading progressbar label.
Currently, it's hardcoded English text.
aria-labelvalue.