Add deprecation notice for fluidattacks/makes integration #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: blaggacao <[email protected]>
Copilot
AI
changed the title
[WIP] fluidattacks/makes is deprecated
Add deprecation notice for fluidattacks/makes integration
Aug 23, 2025
Copilot finished work on behalf of
blaggacao
August 23, 2025 16:28
blaggacao
requested changes
Aug 24, 2025
| removeBy = import ./cells/std/errors/removeBy.nix {inherit inputs;}; | ||
| in { | ||
| # fluidattacks/makes integration deprecation | ||
| mkMakes = removeBy "2025-06-01" '' |
There was a problem hiding this comment.
Please change the date to something in 2026 as the removal date @copilot
There was a problem hiding this comment.
Please move this entire implementation over to the deprecation.nix file. Then back-import it here. Keep your deprecation warning in the deprecation.nix file @copilot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deprecation notices for the
std.lib.dev.mkMakesfunction following the deprecation of thefluidattacks/makesproject in favor of Nix Flakes.Changes
Runtime Warning: Added a
builtins.tracedeprecation warning tosrc/lib/dev/mkMakes.nixthat displays when the function is used:Documentation Updates:
src/lib/dev/mkMakes.mdwith prominent deprecation warning in the function title and descriptiondeprecation.nixMigration Path: The changes maintain backward compatibility while clearly warning users about the deprecation and providing a scheduled removal date of 2025-06-01. Users can continue using the function while planning their migration to native Nix solutions.
This addresses the fluidattacks/makes project deprecation and provides users with clear guidance for migration away from the deprecated tooling.
Fixes #413.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
install.determinate.systemscurl --proto =https --tlsv1.2 -sSf -L https://install.determinate.systems/nix(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.