Fixed #28199 -- Fixed Subquery generating unnecessary/invalid CAST. #8572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charettes @schinckel -- any advice about things to try for a solution? |
|
@timgraham it looks like it's caused by the call to |
Thanks Simon Charette for the fix.
charettes
approved these changes
May 30, 2017
There was a problem hiding this comment.
@timgraham I'm pretty sure the inclusion of this code was a copy-paste leftover of the Case.as_sql() occurrence as it doesn't make much sense to be used here. Thanks for the tests!
|
Yeah, I don't recall whether there was a reason that was there. Probably more that I don't know exactly what it's supposed to do. No failing tests elsewhere means it's either not needed, or needed for something that's not tested, I guess. |
schinckel
approved these changes
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/28199