Update Select2 to version 4.0.7 #11548

codingjoe · 2019-07-08T09:41:12Z

Update vendored Select2 dependency to the latest minor release (4.0.3 -> 4.0.7).

Change log

4.0.7

4.0.6

New features/improvements

Add style property to package.json (Fixed #25138 -- Added view_decorator for CBVs. #5019)
Implement clear and clearing events (SQLCompiler: fix get_order_by's docstring with correct return format #5058)
Add scrollAfterSelect option (Stable/1.8.x #5150)
Add missing diacritics (Fixed #24334 -- Allowed admin password reset to work with non-digit custom user model pk. #4118, Fixed #24496 -- Checked CSRF Referer against CSRF_COOKIE_DOMAIN. #4337, Fixed #25592 -- Fixed misnamed strictly_above PostGIS lookup #5464)

Bug fixes

Fix up arrow error when there are no options in dropdown (Fixed #25254 -- Added attribute in JsonResponse to pass kwargs to json.dumps #5127)
Add ; before beginning of factory wrapper (Fixed #25209 -- Removed parallel=True coverage option #5089)
Fix IE11 issue with select losing focus after selecting an item (Corrected to not erroneously mention email as being required. #4860)
Clear tooltip from select2-selection__rendered when selection is cleared (Update querysets.txt #4640, Doc fix: Tutorial 1: app structure: include migrations dir #4746)
Fix keyboard not closing when closing dropdown on iOS 10 (tutorial01.text light edits #4680)
User-defined types not normalized properly when passed in as data (Fix order of super arguments in SimpleTestCase doc #4632)
Perform deep merge for Defaults.set() (Fixed #24281 -- Improved docs for timezone handling for auto_now and auto_now_add #4364)
Fix "the results could not be loaded" displaying during AJAX request (Fixed #24515 -- Fixed DjangoTranslation plural handling #4356)
Cache objects in Utils.__cache instead of using $.data (Refs #24483 -- Added tests for deconstruction of Field.choices #4346, Update email address in AUTHORS #5486)
Removing the double event binding registration of selection:update (Ticket 24226 #4306)

Accessibility

Improve .select2-hidden-accessible ([1.8.x] Renamed RemovedInDjango20Warning to RemovedInDjango110Warning. #4908)
Add role and aria-readonly attributes to single selection dropdown value (Fixed #24995 -- Fixed renaming a ForeignKey target on MySQL #4881)

Translations

Add Turkmen translations (tk) (Fixed #24743 -- Grouped consecutive migrations in effective migration plan #5125)
Fix error in French translations (Fixed #24305 - Allowed shadowing fields on abstract models #5122)
Add Albanian translation (sq) (Refs #24590 -- Ensured isolation between autodetector tests #5199)
Add Georgian translation (ka) (Ticket#14217 #5179)
Add Nepali translation (ne) (Typo fix #5295)
Add Bangla translation (bn) ([WIP] Fixed #25347 -- Allowed QueryDict.get() to return a list. #5248)
Add removeAllItems translation for clear "x" title (Remove unnecessarily rude terminology. #5291)
Fix wording in Vietnamese translations ([1.8.x] Fixed #25398 -- Revised instances of os.path.join() #5387)
Fix error in Russian translation (Fixed #25517 -- Make ConcatPair.coalesce() idempotent #5401)

Miscellaneous

Remove duplicate CSS selector in classic theme (Fixed #25233 -- Fixed HStoreField.has_changed() handling of initial values. #5115)

4.0.5

Bug fixes

Replace autocapitalize=off with autocapitalize=none ([1.4.x] Fixed #25119 -- Disabled wheel support. #4994)

Translations

Vietnamese: remove an unnecessary quote mark ([WIP] Refs #24121 - Added more reprs #5059)
Czech: Add missing commas and periods (Fixed #25170 -- Made SimpleTestCase.assertXMLEqual() ignore whitespace outside of tags. #5052)
Spanish: Update the 'errorLoading' message (Fixed #22258 -- Added progress status for dumpdata when outputting to file #5032)
Fix typo in Romanian (Fixed typo in docs on translation. #5005)
Improve French translation (Fixed #25115 -- Made admindocs view bookmarklet reverse the URL rather than hardcode it #4988)
Add Pashto translation (ps) (Fixed #25068 Added metaclassmaker to resolve metaclass conflicts #4960)
Add translations for lower and upper Sorbian (dsb and hsb) (Fixed #25059 - validate punycoded TLDs in URLValidator #4949)
Updates to Slovak (Fixed #25017 -- Allowed customizing the settings.DISALLOWED_USER_AGENTS response. #4915)
Fixed Norwegian inputTooShort message (Fixed #24881: clarify order_with_respect_to documentation #4817, 4896)
Add Afrikaans translation (af) (Update ChoiceFieldRenderer object #4850)
Add Bosnian translation (bs) (Fixed #16609 -- Fixed duplicate admin results when searching nested M2M relations #4504)

4.0.4

New features / Improvements

Make tag matching case insensitive [https://github.com/select2/select2/commit/cb9a90457867ffb14c7b1550bb67e872e0a5c2dd, https://github.com/select2/select2/commit/1167bace78cd3b1a918c1b04f3bac54674eab62b]
Support selecting options with blank or 0 option values [https://github.com/select2/select2/commit/16b4840c0e2df0461998e3b464ee0a546173950d, https://github.com/select2/select2/commit/0358ee528765157234643d289bce6b8ca5889c72]

Bug fixes

Fix issue with entire form losing focus when tabbing away from a Select2 control ([WIP] Fixed #24554 -- Added preserve state option to mutate_state #4419)
Fix UMD support for CommonJS [https://github.com/select2/select2/commit/45a877345482956021161203ac789c25f40a7d5e]

Documentation

Github Pages documentation has been deprecated, replaced with https://github.com/select2/docs
Add django-autocomplete-light to integrations [https://github.com/Add django-autocomplete-light to integrations select2/select2#4597]
Correct typo in options page [https://github.com/Correct typo in "options" page select2/select2#4389]
Correct misspelling in AJAX query parameters example [https://github.com/fix(docs): corrected mistype select2/select2#4435]
"highlight" should be "focus" in focus example [https://github.com/docs: more appropriate terminology ("highlight" -> "focus") select2/select2#4441]
Correct misspelling in <select> serialization example [https://github.com/Update select.html select2/select2#4538]
Correct typos in documentation [https://github.com/Fix typos in docs select2/select2#4663]

Translations

Add errorLoading Hungarian translation [https://github.com/select2/select2/commit/7d1d13352321e21670ff1c6cba7413aa264fd57a]
Add errorLoading German translation [https://github.com/select2/select2/commit/4df965219ea4c39147fde9335bc260840465933a]
Add Slovene language [https://github.com/select2/select2/commit/8e6422c570a87da8d89c45daf0d253695a943c84]
Add errorLoading Galician translation [https://github.com/select2/select2/commit/8fcc6202c37f4e06d951342bf142a3b906b6b8e3]
Add errorLoading Thai translation [https://github.com/select2/select2/commit/625fc78ee616baedf64aa37357403b4b72c7363c]
Add searching and errorLoading Finnish translations [https://github.com/Add missing finnish translations select2/select2#4730]
Add errorLoading Turkish translation [https://github.com/select2/select2/commit/fd4a0825315c7055347726d5818c999279f96ff8, https://github.com/select2/select2/commit/751b36767f9f28b9de9428d5e8035c9a404915d9]
Add Armenian language [https://github.com/select2/select2/commit/f6fa52dcc02341df1523f50348f2effc54ee2911]

codingjoe · 2019-07-08T09:49:51Z

Why are you vendoring a javascript library in the first place?

Good question @LemonAndroid! We didn't want to use a CDN as it would break local development. This is something we in GeoDjango, but to be fair, you need an internet connection to see the map data anyways.

It would be more elegant to get the data via npm, no one has build a good release pipeline for that yet.

codingjoe · 2019-07-08T10:01:57Z

@carltongibson I tested it locally, the selenium tests fail, because bowser is too slow. What should I do now?

carltongibson · 2019-07-08T10:04:06Z

Hey @codingjoe.

OK, I'll have a look. (Grrr. Selenium.)

(Comment deleted.)

codingjoe · 2019-07-08T11:12:45Z

cc @kevin-brown

carltongibson · 2019-07-08T15:10:47Z

Grrr. So we're failing on the Selenium builds, which are passing for me locally... (@apollo13 Do you have any thoughts there...?)

I just want to compare the checksums with the official package but, looks good!

codingjoe · 2019-07-09T06:10:49Z

Grrr. So we're failing on the Selenium builds, which are passing for me locally... (@apollo13 Do you have any thoughts there...?)

We could wait until the statement is true, and add a timeout in case it isn't. That is common in selenium, but not really for that scenario. I'll try something.

I just want to compare the checksums with the official package but, looks good!

I took files from the GitHub release. I figured, that's as close to the source as it gets.

codingjoe · 2019-07-09T08:26:49Z

#workedOnMyMachine

carltongibson · 2019-07-09T08:29:14Z

Hey @codingjoe, OK, thanks, I'll have a play... 😬

I took files from the GitHub release. I figured, that's as close to the source as it gets.

I'm quite sure you did. I still feel it's incumbent upon me to verify an error didn't slip in. 🙂

felixxm · 2019-07-09T08:39:59Z

We should add a short release note (Minor features -> django.contrib.admin), e.g.

 * Select2 library is upgraded from version 4.0.3 to 4.0.7.

apollo13 · 2019-07-09T09:22:56Z

Grrr. So we're failing on the Selenium builds, which are passing for me locally... (@apollo13 Do you have any thoughts there...?)

Are they failing consistently on this PR and work on others? Then I fear there is something systematic behind it due to the upgrade? That said, selenium tests are hard to write and tend to break differently in different environments :( Don't have any good ideas on this one.

carltongibson · 2019-07-09T10:20:39Z

OK, thanks for the input @apollo13! I'm about to look into it now... 😬

@codingjoe: Checksums are correct, except for js/i18n/sq,js, which is correct except it has Windows line endings (CRLF) in the select2-4.0.7 distribution, against Unix line endings (LF) in the checkin here. (I would open an issue there but it looks like select2/select2#4703...)

carltongibson · 2019-07-09T14:08:05Z

I think we're looking at (guess) microseconds here. The visually observable behaviour in the browser is correct but putting a breakpoint into the test, the problem results variable is stale (from the previous assertion).

I've tried just adding an additional assert, to buy a little time, but it maybe a new variable name, or breaking the test cases up a bit (or a less heavy wait() than the approach Joe tried in 20f79347dc0bade8043657a0675fe1c08d901845) may be needed.

carltongibson · 2019-07-09T14:51:58Z

Woot. 🎉

carltongibson

OK, bar a squash and the the commit message, this looks good to me. Thanks @codingjoe!

carltongibson · 2019-07-09T14:55:34Z

Sorry, I got excited by the tests passing. Release note. (Can you add that and squash @codingjoe? If not I'll do it tomorrow.)

Premature. (Release note missing)

codingjoe · 2019-07-09T17:21:34Z

@carltongibson 🆗 it's done!

django deleted a comment Jul 8, 2019

carltongibson self-requested a review July 8, 2019 10:03

django locked as spam and limited conversation to collaborators Jul 8, 2019

django deleted a comment Jul 8, 2019

django unlocked this conversation Jul 8, 2019

carltongibson self-assigned this Jul 8, 2019

django deleted a comment from carltongibson Jul 8, 2019

carltongibson force-pushed the update/select2/4.0.7 branch from 20f7934 to 8a5347b Compare July 9, 2019 14:03

django deleted a comment from carltongibson Jul 9, 2019

carltongibson previously approved these changes Jul 9, 2019

View reviewed changes

Update Select2 to version 4.0.7

9af872a

codingjoe force-pushed the update/select2/4.0.7 branch from 8a5347b to 9af872a Compare July 9, 2019 16:43

carltongibson approved these changes Jul 10, 2019

View reviewed changes

carltongibson merged commit 00d4e6f into django:master Jul 10, 2019

codingjoe deleted the update/select2/4.0.7 branch July 10, 2019 12:38

Uh oh!

Update Select2 to version 4.0.7 #11548

Update Select2 to version 4.0.7 #11548

Uh oh!

Conversation

codingjoe commented Jul 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

4.0.7

New features/improvements

Bug fixes

Miscellaneous

4.0.6

New features/improvements

Bug fixes

Accessibility

Translations

Miscellaneous

4.0.5

Bug fixes

Translations

4.0.4

New features / Improvements

Bug fixes

Documentation

Translations

Uh oh!

codingjoe commented Jul 8, 2019

Uh oh!

codingjoe commented Jul 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carltongibson commented Jul 8, 2019

Uh oh!

codingjoe commented Jul 8, 2019

Uh oh!

carltongibson commented Jul 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codingjoe commented Jul 9, 2019

Uh oh!

codingjoe commented Jul 9, 2019

Uh oh!

carltongibson commented Jul 9, 2019

Uh oh!

felixxm commented Jul 9, 2019

Uh oh!

apollo13 commented Jul 9, 2019

Uh oh!

carltongibson commented Jul 9, 2019

Uh oh!

carltongibson commented Jul 9, 2019

Uh oh!

carltongibson commented Jul 9, 2019

Uh oh!

carltongibson left a comment

Choose a reason for hiding this comment

Uh oh!

carltongibson commented Jul 9, 2019

Uh oh!

codingjoe commented Jul 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codingjoe commented Jul 8, 2019 •

edited

Loading

codingjoe commented Jul 8, 2019 •

edited

Loading

carltongibson commented Jul 8, 2019 •

edited

Loading