Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed #31377 -- Disabled grouping by aliases on QuerySet.values()/values_list() when they collide with field names. #12589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fixed #31377 -- Disabled grouping by aliases on QuerySet.values()/values_list() when they collide with field names. #12589

merged 1 commit into from
Mar 25, 2020

Conversation

hramezani
Copy link
Member

Fixes ticket 31377.

charettes
charettes reviewed Mar 19, 2020
View reviewed changes
@hramezani hramezani force-pushed the ticket_31377 branch 2 times, most recently from 223e5bb to 03d788e Compare March 19, 2020 20:16
charettes
charettes reviewed Mar 19, 2020
View reviewed changes
charettes
charettes reviewed Mar 19, 2020
View reviewed changes
@hramezani hramezani force-pushed the ticket_31377 branch 3 times, most recently from 3d5e6a1 to 8e647db Compare March 19, 2020 22:17
@hramezani
Copy link
Member Author

Don't know what is the problem with the newly added test. It works without problem in my local setup.
It is AssertionError not the ProgrammingError that was mentioned on the ticket

@felixxm felixxm self-assigned this Mar 20, 2020
felixxm
felixxm reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramezani Thanks for this patch 👍 I pushed edits related to my comments.

@felixxm felixxm force-pushed the ticket_31377 branch 3 times, most recently from fd68f66 to d40cb9d Compare March 24, 2020 12:02
@felixxm felixxm changed the title Fixed #31377 -- Fixed collison between annotation with involved table column names. Fixed #31377 -- Disabled grouping by aliases on QuerySet.values()/values_list() when they collide with field names. Mar 25, 2020
@hramezani @felixxm
Fixed #31377 -- Disabled grouping by aliases on QuerySet.values()/val…
10866a1 
…ues_list() when they collide with field names.

Regression in fb3f034.

Thanks Holovashchenko Vadym for the report.
@felixxm felixxm merged commit 10866a1 into django:master Mar 25, 2020
@millerdev millerdev mentioned this pull request Apr 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixxm felixxm felixxm left review comments

+1 more reviewer

@charettes charettes charettes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@felixxm felixxm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hramezani @charettes @claudep @felixxm