Fixed #23560 -- Fixed MigrationWrite to handle builtin types without imp... #3281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/migrations/test_writer.py
Outdated
|
Add 1.7.1 release notes and backport? |
django/db/migrations/writer.py
Outdated
There was a problem hiding this comment.
this line is very hard to read maybe you should do something like this:
builtins = 'builtins' if six.PY3 else '__builtin__'
if module == builtins:
...There was a problem hiding this comment.
Thanks for the feedback however I wrote it that way specifically to minimize the work required when we drop support for PY2.
There was a problem hiding this comment.
Maybe wrapping the inline conditional in parentheses would help readability.
There was a problem hiding this comment.
I meant module == ('builtins' if six.PY3 else '__builtin__')
There was a problem hiding this comment.
Got it, it looks better indeed.
…imports. Thanks Tim Graham for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...orts.