Fixed #23609 -- Changed behavior when dropping a NULL constraint to update rows with NULL to default #3320

MarkusH · 2014-10-06T23:56:25Z

Ticket: https://code.djangoproject.com/ticket/23609

charettes · 2014-10-06T23:59:27Z

Buildbot, test this please.

charettes · 2014-10-07T00:00:49Z

tests/schema/tests.py

assertIsNone

charettes · 2014-10-07T14:35:52Z

django/db/backends/schema.py

Why are you setting it to None here? It looks like it's not used between this line and line #581.

charettes · 2014-10-07T21:17:36Z

django/db/backends/schema.py

we didn't

loic · 2014-10-08T06:09:25Z

Patch is looking good, but shouldn't the questioner play a part in this? The same way that adding a NOT NULL field triggers it, see ask_not_null_addition.

MarkusH · 2014-10-08T11:59:53Z

I added a commit to integrate the migration questioner.

MarkusH · 2014-10-08T12:46:02Z

Tests failed because of some checkout issue

collinanderson · 2014-10-08T12:50:16Z

buildbot, retest this please.

loic · 2014-10-08T17:06:35Z

django/db/migrations/questioner.py

Maybe a little too familiar wording? Also a suggestion of what one may want to do would be helpful, for instance: (e.g. deal with existing NULL using a separate RunSQL or RunPython operation).

timgraham · 2014-10-09T12:45:39Z

django/db/migrations/questioner.py

is print_function needed? it doesn't appear in the rest of the code base.

I guess it's a bit defensive, it helps ensuring that behavior is always identical.

print("hello",) would give different results in PY2 and PY3 for instance.

It's the right way to support Python 2 and Python 3. See PEP 3105. I mean, I can drop it again, but I don't see the reason for that.

timgraham · 2014-10-09T13:44:45Z

django/db/migrations/questioner.py

Think the position of the newline should be altered -- above it seems to be so that the line fits in a standard size terminal window -- here the first line is too long -- should break after "non-nullable" instead.

Also message above doesn't have quotes around the model name.

Once (field_name, model_name) expand I doubt it'll fit in 80chars even above.

Good catch on the quote inconsistency.

I agree on the quotes, but I'm with @loic on the word wrap.

Hm yea, I wonder if we should just remove the newlines then and let the terminal window wrap the lines. It looks funny now to have a newline after the semicolon. Actually would django.utils.text work to automatically insert the newlines?

Yeah, we could use django.utils.text.wrap() in the questioner, but I'd do that in a separate commit / pull request.

timgraham · 2014-10-09T13:55:59Z

django/db/migrations/questioner.py

"operation in the new migration file before the AlterField operation" (to give better guidance?)
need newlines in the this message

…olumn into a NOT NULL one due to existing rows Thanks to Simon Charette, Loic Bistuer and Tim Graham for the review.

loic · 2014-10-09T15:53:44Z

Merged in f633ba7 and 71988ed. Thanks!

charettes reviewed Oct 7, 2014
View reviewed changes

tests/schema/tests.py Outdated

Copy link

Member

charettes Oct 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assertIsNone

MarkusH force-pushed the ticket23609 branch 3 times, most recently from f6a28f9 to 7600bb3 Compare October 7, 2014 11:07

MarkusH changed the title ~~Fixed #23609 -- Changed the way the table is remade in SQLite if a NULL constraint has changed~~ Fixed #23609 -- Changed behavior when dropping a NULL constraint to update rows with NULL to default Oct 7, 2014

charettes reviewed Oct 7, 2014
View reviewed changes

MarkusH force-pushed the ticket23609 branch from 7600bb3 to 400a40b Compare October 7, 2014 15:25

charettes reviewed Oct 7, 2014
View reviewed changes

django/db/backends/schema.py Outdated

Copy link

Member

charettes Oct 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't

MarkusH force-pushed the ticket23609 branch from 400a40b to ddf46c0 Compare October 7, 2014 21:44

MarkusH force-pushed the ticket23609 branch from e1accad to 824912d Compare October 8, 2014 12:11

loic reviewed Oct 8, 2014
View reviewed changes

MarkusH force-pushed the ticket23609 branch 2 times, most recently from 7d06735 to 02bbb7f Compare October 9, 2014 11:33

timgraham reviewed Oct 9, 2014
View reviewed changes

MarkusH force-pushed the ticket23609 branch from 02bbb7f to 7b192aa Compare October 9, 2014 13:05

timgraham reviewed Oct 9, 2014
View reviewed changes

Fixed #23609 -- Fixed IntegrityError that prevented altering a NULL c…

b43603e

…olumn into a NOT NULL one due to existing rows Thanks to Simon Charette, Loic Bistuer and Tim Graham for the review.

MarkusH force-pushed the ticket23609 branch from 7b192aa to b43603e Compare October 9, 2014 14:18

loic closed this Oct 9, 2014

MarkusH deleted the ticket23609 branch October 9, 2014 23:04

Uh oh!

Fixed #23609 -- Changed behavior when dropping a NULL constraint to update rows with NULL to default #3320

Fixed #23609 -- Changed behavior when dropping a NULL constraint to update rows with NULL to default #3320

Uh oh!

Conversation

MarkusH commented Oct 6, 2014

Uh oh!

charettes commented Oct 6, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic commented Oct 8, 2014

Uh oh!

MarkusH commented Oct 8, 2014

Uh oh!

MarkusH commented Oct 8, 2014

Uh oh!

collinanderson commented Oct 8, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic commented Oct 9, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants