Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug fix: Save previous parameters & other nits #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkweiss31 merged 2 commits into from
Oct 29, 2025
Merged

Bug fix: Save previous parameters & other nits #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb540e
bug fix: save prev parameters & other nits
HarshBabla99 Oct 28, 2025
88a9b24
ruff
HarshBabla99 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions qontrol/optimize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,11 @@ def step(
print(costs, cost_values[0])

# Save logic
save_period = opt_options['save_period']
if filepath is not None and epoch > 0 and epoch % save_period == 0:
if (
filepath is not None
and epoch > 0
and epoch % opt_options['save_period'] == 0
):
_save(
cost_values_over_epochs,
total_cost_over_epochs,
Expand All @@ -188,6 +191,7 @@ def step(
)
last_save_epoch = epoch
parameters_since_last_save = _init_saved_parameters(parameters)

# Plot the cost values as well as other desired quantities
if (
opt_options['plot']
Expand All @@ -212,6 +216,7 @@ def step(
)
if termination_key != -1:
break
previous_parameters = parameters

except KeyboardInterrupt:
pass
Expand Down Expand Up @@ -261,8 +266,7 @@ def loss(
) -> [float, Array]:
result, H = model(parameters, method, gradient, dq_options)
cost_values, terminate = zip(*costs(result, H, parameters), strict=True)
total_cost = jax.tree.reduce(jnp.add, cost_values)
total_cost = jnp.log(jnp.sum(jnp.asarray(total_cost)))
total_cost = jnp.log(jax.tree.reduce(jnp.add, cost_values))
expects = result.expects if hasattr(result, 'expects') else None
return total_cost, (total_cost, cost_values, terminate, expects)

Expand Down