[Data] new functional for creating data splits in graph#5418
[Data] new functional for creating data splits in graph#5418mufeili merged 21 commits intodmlc:masterfrom
Conversation
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
|
I have just made a minor fix in the implementation of data split, which should not induce any changes in test coverage. By the way, it is not clear for me why CI test fails in the |
|
The failures were not relevant to your changes. Let me trigger the tests again. |
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Done. |
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
|
@gvbazhenov You need to fix the issues raised by Lint / lintrunner. Click the Details button to see the requests. |
…into structural-shifts
…into structural-shifts
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Done in commit d60cf9a. |
|
@jermainewang @mufeili @frozenbugs Thank you very much for your help and guidance. |
|
@gvbazhenov Thank you for the great job! |
* new functional for creating data splits in graph * minor fix in data split implementation * apply suggestions from code review Co-authored-by: Mufei Li <[email protected]> * refactoring + unit tests * fix test file name * move imports to the top * Revert "fix test file name" This reverts commit 126323e. * remove nccl submodule * address linter issues --------- Co-authored-by: Mufei Li <[email protected]> Co-authored-by: Hongzhi (Steve), Chen <[email protected]>
Description
New functional for creating data splits, which allows to induce distributional shifts in graph and conduct experiments with graph models in more challenging setups.
Unfortunately, I did not manage to cover changes with tests, as I could not understand what is the proper way to create an environment
pytorch-ci, which is expected intask_unit_test.sh. In my custom environment, some tests failed because of incorrect package versions (module 'numpy' has no attribute 'asscalar'), lack of some other side packages (no module named 'ogb'), etc.However, I have successfully built DGL from source with new functions and checked that everything works fine.
Checklist
Please feel free to remove inapplicable items for your PR.