Implement check for active runs #4016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good. Recommendation, once you setup another replay instance, why don't you inject some of the problematic runs (system doesn't even need to be up for it) and then run the fix script ? That way you can test what it is doing and if things look alright after. |
Implement tool a la fixRunStuckInCloseout to check runs which have the top fileset open for express and repack, it looks into inconsistencies in the streamer and lumi sections. It can also wipe information for incomplete lumis. Fixes dmwm#4013
Contributor
Author
|
I thought I had commented on this one already, I tested the functionality on the replay instance we used for the merge repack issue. I have been also actively using the script in the commissioning system and it works as expected. |
hufnagel
added a commit
that referenced
this pull request
Dec 6, 2012
Implement check for active runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement tool a la fixRunStuckInCloseout to check
runs which have the top fileset open for
express and repack, it looks into inconsistencies
in the streamer and lumi sections. It can also
wipe information for incomplete lumis.
Fixes #4013
Please review, I have tested all completely but the doChange code path after Line #188. @hufnagel could you please look at that path in particular, we have runs in the WMAT0 to test it a second look before trying it would be best.