fix problem in lumi closing query #4028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a consistency to the discovery of closed lumis in the SM database and tried to be clever by integrating it into the discovery query. Turns out I was too clever as the new query has a problem and doesn't find all closed lumis. Revert to the previous discovery version query and add the check as an extra query in the same DAO. Maybe not as efficient, but it's safer and it's also the same way this is implemented in the old Tier0.
hufnagel
added a commit
that referenced
this pull request
Jan 16, 2013
fix problem in lumi closing query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a consistency to the discovery of closed lumis
in the SM database and tried to be clever by integrating
it into the discovery query. Turns out I was too clever
as the new query has a problem and doesn't find all
closed lumis. Revert to the previous discovery version
query and add the check as an extra query in the same DAO.
Maybe not as efficient, but it's safer and it's also the
same way this is implemented in the old Tier0.