Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ticoann
Copy link
Contributor

@ticoann ticoann commented Jan 7, 2015

need to update dmwm/WMCore#5555 together

@ticoann
Copy link
Contributor Author

ticoann commented Jan 7, 2015

@hufnagel, please review.

@hufnagel
Copy link
Member

hufnagel commented Jan 7, 2015

Looks good, I assume I can merge this as soon as you merge the relevant WMCore code ?

@hufnagel
Copy link
Member

hufnagel commented Jan 7, 2015

What about the PromptReco spec though ? That's in WMCore and can in principle be used by both normal central Ops requests (if they so desire) and the Tier0. So I need to override a few more things there, as before ?

@ticoann
Copy link
Contributor Author

ticoann commented Jan 8, 2015

I clean up a little further. Please review. For the PromptReco, I am not quite sure how to set the flag as you mention when we chat. For now I update necessary values (CouchCacheID, etc) as optional arguments
https://github.com/dmwm/WMCore/pull/5555/files#diff-90f4b259876ad7414f235789db2dbae4R366

@hufnagel
Copy link
Member

hufnagel commented Jan 8, 2015

Still don't really like it, especially in light of what we discussed about the PromptReco spec.

Can't we get rid of the "useReqMgr = False" statements and the Repack and Express specs just override the appropriate parameters to make them optional with reasonable defaults ? I think that's cleaner. PromptReco could do the same (and then stays usable for both Tier0 and Requests).

@ticoann
Copy link
Contributor Author

ticoann commented Jan 8, 2015

I think you are right that is cleaner I will do that way. I was just trying remove duplicate definition if it is commonly used, but I agree that it is not good to have flag to do different things in the same method

@ticoann
Copy link
Contributor Author

ticoann commented Jan 11, 2015

Hi Dirk, I updated code as you suggested. dmwm/WMCore#5555 is updated accordingly

@hufnagel
Copy link
Member

Looks good, but let me run a Tier0 replay to check it out...

@hufnagel
Copy link
Member

Replay fails, commented on the reason in dmwm/WMCore#5555

@hufnagel
Copy link
Member

With the changes in dmwm/WMCore#5555 everything works now.

@hufnagel hufnagel closed this Jan 13, 2015
@hufnagel hufnagel reopened this Jan 13, 2015
hufnagel added a commit that referenced this pull request Jan 13, 2015
change the default spec argument
@hufnagel hufnagel merged commit b5856aa into dmwm:master Jan 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants