-
Notifications
You must be signed in to change notification settings - Fork 68
change the default spec argument #4108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hufnagel, please review. |
|
Looks good, I assume I can merge this as soon as you merge the relevant WMCore code ? |
|
What about the PromptReco spec though ? That's in WMCore and can in principle be used by both normal central Ops requests (if they so desire) and the Tier0. So I need to override a few more things there, as before ? |
|
I clean up a little further. Please review. For the PromptReco, I am not quite sure how to set the flag as you mention when we chat. For now I update necessary values (CouchCacheID, etc) as optional arguments |
|
Still don't really like it, especially in light of what we discussed about the PromptReco spec. Can't we get rid of the "useReqMgr = False" statements and the Repack and Express specs just override the appropriate parameters to make them optional with reasonable defaults ? I think that's cleaner. PromptReco could do the same (and then stays usable for both Tier0 and Requests). |
|
I think you are right that is cleaner I will do that way. I was just trying remove duplicate definition if it is commonly used, but I agree that it is not good to have flag to do different things in the same method |
|
Hi Dirk, I updated code as you suggested. dmwm/WMCore#5555 is updated accordingly |
|
Looks good, but let me run a Tier0 replay to check it out... |
|
Replay fails, commented on the reason in dmwm/WMCore#5555 |
|
With the changes in dmwm/WMCore#5555 everything works now. |
change the default spec argument
need to update dmwm/WMCore#5555 together