-
Notifications
You must be signed in to change notification settings - Fork 68
Prod replay config merge #4357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prod replay config merge #4357
Conversation
…eeded to make _0T datasets (might want to do this everywhere?)
| setConfigVersion(tier0Config, "replace with real version") | ||
|
|
||
| # replay these run | ||
| #setInjectRuns(tier0Config, [ 289461 ]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really want a replay run in the production config ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was mostly intended as a reminder, but it might not be necessary now we have synced the replay config. @johnhcasallasl , what do you think?
|
|
||
| for dataset in datasets: | ||
| addDataset(tier0Config, dataset, | ||
| addDataset(tier0Config, dataset+"_0T", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you restructure the config like this, can you please do it for all datasets ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can do it. It was just taking a while, so I only did it to the datasets I was already restructuring for other reasons.
Also brings configs up to date with 921, latest alca matrix, and latest global tags.