Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set PNN instead of PSNs for wmbs file locations #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hufnagel merged 2 commits into from
Dec 13, 2017
Merged

Set PNN instead of PSNs for wmbs file locations #4402

hufnagel merged 2 commits into from
Dec 13, 2017

Conversation

@amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Dec 8, 2017

T0 version of dmwm/WMCore#8280

@hufnagel @ticoann please review. Dirk, can you ask T0 Ops to run a replay to test these changes (once you're happy with them)?

@hufnagel
Copy link
Member

hufnagel commented Dec 8, 2017

What WMCore tag should this use ? T0 Ops can't run a replay until I at least confirm basic compatibility with that tag. Currently T0 is at 1.1.6. Guess I should switch directly yo 1.1.10 ?

@ticoann
Copy link
Contributor

ticoann commented Dec 8, 2017

The tag which include this change is 1.1.10.pre1

hufnagel
hufnagel reviewed Dec 8, 2017
View reviewed changes
src/python/T0/WMBS/Oracle/RunConfig/InsertStreamer.py Outdated
(FILEID, LOCATION)
VALUES (wmbs_file_details_SEQ.nextval, (SELECT id FROM wmbs_location WHERE site_name = 'T0_CH_CERN'))
(FILEID, PNN)
VALUES (wmbs_file_details_SEQ.nextval, (SELECT id FROM wmbs_pnns WHERE pnn = 'T0_CH_CERN'))
Copy link
Member

@hufnagel hufnagel Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHERE pnn = 'T0_CH_CERN_Disk'

Copy link
Contributor Author

@amaltaro amaltaro Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it soon.

@hufnagel
Copy link
Member

hufnagel commented Dec 8, 2017

Replay still dies with

2017-12-08 18:51:37,053:140257366316800:ERROR:BaseWorkerThread:Error in worker algorithm (1):
Backtrace:
<T0Component.Tier0Feeder.Tier0FeederPoller.Tier0FeederPoller object at 0x7f9036806410> 'NoneType' object is not iterable File "/data/tier0/srv/wmagent/2.1.0/sw/slc6_amd64_gcc493/cms/wmagent/1.1.6.patch5/lib/python2.7/site-packages/WMCore/WorkerThreads/BaseWorkerThread.py", line 183, in call
tSpent, results, _ = self.algorithm(parameters)

2017-12-08 18:51:37,053:140257366316800:INFO:Harness:>>>Terminating worker threads
2017-12-08 18:51:37,068:140257366316800:ERROR:BaseWorkerThread:Error in event loop (2): <T0Component.Tier0Feeder.Tier0FeederPoller.Tier0FeederPoller object at 0x7f9036806410> 'NoneType' object is not iterable
Backtrace:
File "/data/tier0/srv/wmagent/2.1.0/sw/slc6_amd64_gcc493/cms/wmagent/1.1.6.patch5/lib/python2.7/site-packages/WMCore/WorkerThreads/BaseWorkerThread.py", line 211, in call
raise ex

2017-12-08 18:51:37,068:140257366316800:INFO:BaseWorkerThread:Worker thread <T0Component.Tier0Feeder.Tier0FeederPoller.Tier0FeederPoller object at 0x7f9036806410> terminated

Have you run any functional tests with 1.1.10.pre1 yet ?

@amaltaro
Copy link
Contributor Author

amaltaro commented Dec 8, 2017

About this failure on Tier0FeederPoller. You need to update the code of any components (inheriting from BaseWorkerThread) with a decorator for the algorithm method
https://github.com/dmwm/WMCore/blob/master/src/python/WMComponent/ErrorHandler/ErrorHandlerPoller.py#L29
https://github.com/dmwm/WMCore/blob/master/src/python/WMComponent/ErrorHandler/ErrorHandlerPoller.py#L370

See original PR changes here dmwm/WMCore#8165

@amaltaro amaltaro force-pushed the file-location-worker branch from 8e5905f to a42142c Compare December 8, 2017 18:43
@hufnagel
Copy link
Member

hufnagel commented Dec 8, 2017

Seems to be working now

2017-12-08 21:14:15,512:140208127547136:INFO:BaseWorkerThread:Tier0FeederPoller took 65.127 secs to execute

Will keep watching the replay to make sure data discovery in the JobCreator also works (since these queries were also changed).

@hufnagel
Copy link
Member

hufnagel commented Dec 8, 2017

You forgot to change a GROUP statement in GetAvailableRepackMergeFiles.py, JobCreator crashes in the RepackMerge subscriptions.

@amaltaro amaltaro force-pushed the file-location-worker branch from a42142c to 715f089 Compare December 9, 2017 23:30
@amaltaro
Copy link
Contributor Author

amaltaro commented Dec 9, 2017

Sorry Dirk, GetAvailableRepackMergeFiles.py has been fixed.

@hufnagel
Copy link
Member

hufnagel commented Dec 13, 2017

Ok, tested in a replay, works now. Merging this.

@hufnagel hufnagel merged commit de82f5f into dmwm:master Dec 13, 2017
@hufnagel hufnagel mentioned this pull request Dec 13, 2017
Closed
@amaltaro
Copy link
Contributor Author

amaltaro commented Dec 14, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hufnagel hufnagel hufnagel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amaltaro @hufnagel @ticoann