Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vytjan
Copy link
Contributor

@vytjan vytjan commented Sep 4, 2019

@vytjan
Copy link
Contributor Author

vytjan commented Sep 6, 2019

@hufnagel Dirk, do you think this looks reasonable to be merged?
I ran a replay testing this PR and it worked fine.

@hufnagel
Copy link
Member

hufnagel commented Sep 9, 2019

I assume you ran a replay with a recent run and it worked. Only thing I would worry about is what if you want to replay older runs. Do the new OMS database tables contain records for older runs that we potentially want to replay? Even if not it doesn't mean we can't merge this as-is. But we should at least be aware if this puts in a age limit for older runs to be replayed (and then we might as well get rid of this old saved streamers for these runs).

@hufnagel
Copy link
Member

hufnagel commented Sep 9, 2019

Otherwise this looks good.

@vytjan
Copy link
Contributor Author

vytjan commented Sep 10, 2019

OMS database contains all records that are on WBM, starting from the first commissioning runs in 2009 (run 30108, /cdaq/cosmic/commissioning2009/MWGR/MWGR46/HLT_L1override/V2).
So this PR should be fine for any runs and we don't really need any additional age limit, etc.
Thanks for your feedback, Dirk.

@vytjan
Copy link
Contributor Author

vytjan commented Sep 16, 2019

test this please

1 similar comment
@germanfgv
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Container Tests
Unit tests finished

@germanfgv
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Container Tests
Unit tests finished

@germanfgv
Copy link
Contributor

run replay please

@germanfgv
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Container Tests
Unit tests finished

@germanfgv
Copy link
Contributor

run replay please

@dmwm dmwm deleted a comment from cmsdmwmbot Feb 8, 2021
@dmwm dmwm deleted a comment from cmsdmwmbot Feb 8, 2021
@cmsdmwmbot
Copy link

!!! Couldn't read commit file !!!

@germanfgv germanfgv merged commit 987a65d into dmwm:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants