Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[build] Add requirements.txt #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
germanfgv merged 1 commit into from
Oct 29, 2020
Merged

[build] Add requirements.txt #4549

germanfgv merged 1 commit into from
Oct 29, 2020

Conversation

@mapellidario
Copy link
Member

@mapellidario mapellidario commented Oct 28, 2020

As discussed privately with @amaltaro and in WMCore dev weekly meetings, I open this PR to provide T0 with its own requirements.txt file, based on its spec file.

Details of the spec file:

The requirements.txt file is build with

  • mapellidario/cmssw-dist-parse, tag 0.1
  • with the command python3 parse_spec.py -d /path/to/github.com/cmsdist/ -f t0.spec --no-recursive
  • with some manual changes to cheetah, cx-oracle and mysqldb-python package names

@mapellidario
[build] Add requirements.txt
8c1fdad 
Based on cms-sw/cmsdist
* branch: comp_gcc630 , https://github.com/cms-sw/cmsdist/tree/comp_gcc630
* commit: 9e502ba, https://github.com/cms-sw/cmsdist/tree/9e502ba45b7dd50315872c72fa2b146013d811b2

produced with
* https://github.com/mapellidario/cmssw-dist-parse/releases/tag/0.1
* python3 parse_spec.py -d /path/to/github.com/cmsdist/ -f t0.spec --no-recursive
@cmsdmwmbot
Copy link

cmsdmwmbot commented Oct 28, 2020

Can one of the admins verify this patch?

@germanfgv
Copy link
Contributor

germanfgv commented Oct 28, 2020

Hi @mapellidario. Thank you for providending the file. Could you please clarify how will this affect the release building process for us at Tier0?

We are about to create a new tag based in WMCore 1.4.1.patch4. Usually we would modify t0.spec to update WMCore version and requirements.

@mapellidario
Copy link
Member Author

mapellidario commented Oct 28, 2020

I would leave any definitive comment to @amaltaro, but as far as I have understood your current build process is not going to change any time soon.
This will be used in the future (I am not able to provide a timescale) if and when the build process will be based more on pip and less on spec files.

Please Alan, correct me if I am wrong.

@amaltaro
Copy link
Contributor

amaltaro commented Oct 29, 2020

That's correct, it does not change anything in the build process.
This requirements.txt file is important because it provides a list of dependencies which T0 depends on. Be that a human or a machine in the future.
In addition to that, you get automated GH alerts when any of those software + version has a public security issue. With that said, it's very important that we keep it up-to-date (especially important to me, because if we change dependencies for WMAgent, it will likely affect T0 too, so I need to make sure to feed that information back here).

In short, it can be merged at any time it's convenient to you.
Thanks for putting this PR in, Dario.

@germanfgv germanfgv merged commit ef2188c into dmwm:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mapellidario @cmsdmwmbot @germanfgv @amaltaro