ConfigurableStreamMemory #4597
Merged
ConfigurableStreamMemory #4597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Container Tests |
|
Very clean PR. Thanks for following our suggestions. I'll leave it to @germanfgv to review and approve |
germanfgv
approved these changes
Aug 5, 2021
Contributor
germanfgv
left a comment
There was a problem hiding this comment.
It looks very good. Please add the new attribute to the ProdOffline config and we can merge
Set the memory of streams configurable via addRepackConfig
70eba60 to
f6da70a
Compare
|
Container Tests |
Contributor
|
This PR is ready. I'll merge it to master. Thank you @jhonatanamado |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the memory of streams configurable via addRepackConfig.