Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix duplicated DQM sequences for MinimumBias PDs #4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mmusich wants to merge 2 commits into from
Closed

fix duplicated DQM sequences for MinimumBias PDs #4625

mmusich wants to merge 2 commits into from

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 18, 2021

Casually looking at the T0 configuration I noticed that e.g.:

{
  "run": 345687, 
  "write_miniaod": true, 
  "scram_arch": "slc7_amd64_gcc900", 
  "write_aod": true, 
  "write_reco": false, 
  "alca_skim": "SiStripCalZeroBias,SiStripCalMinBias,TkAlMinBias", 
  "cmssw": "CMSSW_12_0_2_patch1", 
  "physics_skim": null, 
  "write_dqm": true, 
  "scenario": "ppEra_Run3", 
  "global_tag": "120X_dataRun3_Prompt_v2", 
  "multicore": 8, 
  "dqm_seq": "@common,@commonSiStripZeroBias,@ecal,@hcal,@muon,@jetmet", 
  "primary_dataset": "MinimumBias"
}

while @common and @commonSiStripZeroBias have many sequences in common, excepted the Pixel, Strip and Tracking DQM sequences.

https://github.com/cms-sw/cmssw/blob/027525058713f5a07c90d0530bb8c4a7448d3306/DQMOffline/Configuration/python/autoDQM.py#L9-L11

vs

https://github.com/cms-sw/cmssw/blob/027525058713f5a07c90d0530bb8c4a7448d3306/DQMOffline/Configuration/python/autoDQM.py#L17-L19

I think only @commonSiStripZeroBias is the one to keep.
@jfernan2 @tvami

@cmsdmwmbot
Copy link

cmsdmwmbot commented Oct 18, 2021

Can one of the admins verify this patch?

@jfernan2
Copy link

jfernan2 commented Oct 18, 2021

I totally agree, also to be in sync with ZeroBias definition.
Thanks!

@germanfgv
Copy link
Contributor

germanfgv commented Oct 18, 2021

Thanks for noticing @mmusich. I'm guessing, since these sequences have been there for a while, that this is not an urgent change. Would it be ok to keep these changes until the next testing cycle or is it important to have in production for Pilot Beam?

@mmusich
Copy link
Contributor Author

mmusich commented Oct 18, 2021 •
edited
Loading

@germanfgv There's no urgency. I made the PR just to avoid forgetting.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 3, 2021

coming back to this after the beam test, kindly pinging @germanfgv

@germanfgv
Copy link
Contributor

germanfgv commented Nov 3, 2021

Thanks for the reminder, I'll start the replay

@germanfgv
Copy link
Contributor

germanfgv commented Nov 3, 2021

run replay please

@cmsdmwmbot
Copy link

cmsdmwmbot commented Nov 3, 2021

Replay testing PR 'fix duplicated DQM sequences for MinimumBias PDs'
An automatic replay has been requested by GitHub.
Here is a brief description of the replay.
Github PR : #4625
Injected runs : 346062
CMSSW release : CMSSW_12_0_3_patch1
Tier0 release : 3.0.1
ppScenario : ppEra_Run3
Tier0 Config : https://cmst0.web.cern.ch/CMST0/tier0/offline_config/ReplayOfflineConfiguration_047.php
Contatiner ID : 1
Jenkins Build : https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-T0-PR-test-job/338/Jira Issue : https://its.cern.ch/jira/browse/CMSTZDEV-694

@germanfgv
Copy link
Contributor

germanfgv commented Nov 5, 2021

@mmusich the replay finished without issues. We can make this changes in the next production configuration update.

@germanfgv
Copy link
Contributor

germanfgv commented Nov 18, 2021

Merged to master in #4634. This PR can me closed.

@germanfgv germanfgv closed this Nov 18, 2021
@mmusich mmusich deleted the removeDuplicatedEntry branch November 18, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmusich @cmsdmwmbot @jfernan2 @germanfgv