-
Notifications
You must be signed in to change notification settings - Fork 68
Make Express and Promt memory configurable #4638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
germanfgv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clarify the BaseMemory value. Other than that this seems fine.
|
|
||
| specArguments['Memory'] = baseMemory + perCoreMemory | ||
|
|
||
| baseMemory = 500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Dima's comment on Slack, I understand that we don't want to assign this 500MB base memory. We want to assign 2GB/core, and use additianal memory only in case of emergency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is it different for Express?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned during the meeting we should fit CMS infrastructure requirements, that means 2GB/core for any type of job. With the previous formula Tier0 was given in some cases more than 2GB/core so I will start to test this PR with the runs from 2021 and start to validate which jobs were requiring more than 2GB/core
95379f9 to
9ad3c2a
Compare
|
Changes were tested with different replays. No issues to report only 1 paused job requesting more than 2Gb/core while testing with the run 347028. Same job reported here https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/2321.html |
Add an option to configure the max memory per core for Express and Promt configurable via Configfile.
9ad3c2a to
32c56be
Compare
germanfgv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems fine! Thanks for the changes @jhonatanamado
Add an option to configure the max memory per core for Express and Promt configurable via Configfile.