Add lifetime to dataset from ConfigFile #4642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanfgv
reviewed
Jan 26, 2022
Contributor
germanfgv
left a comment
There was a problem hiding this comment.
Looks good, just a couple of comments about logging
decdcf0 to
bb040b6
Compare
91c7fe0 to
0071843
Compare
germanfgv
approved these changes
Apr 12, 2022
Contributor
germanfgv
left a comment
There was a problem hiding this comment.
This is ready to be merged
Contributor
|
@jeyserma Can you comment on the default lifetime that we should give to our subscriptions? |
|
Let's set 3 months as default till we have a better number. |
3455ec7 to
37490d0
Compare
Add lifetime for dataset (RucioContainerRules) that will be subscribed to disk sites via ConfigFile
37490d0 to
2e356dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lifetime for dataset (RucioContainerRules) that will be subscribed to only disk sites via our ConfigFile